Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sector-storage/mock: improve mocked readpiece #5208

Merged
merged 1 commit into from
Jan 5, 2021
Merged

sector-storage/mock: improve mocked readpiece #5208

merged 1 commit into from
Jan 5, 2021
+1 −1

Conversation

jsign
Copy link
Contributor

@jsign jsign commented Dec 16, 2020

This is an old improvement spotted by @arajasek when we were trying to figure out the cause of this panic:

2020-12-16T10:18:09.309-0300    INFO    markets loggers/loggers.go:25   retrieval event {"name": "ClientEventOpen", "deal ID": "0", "state": "DealStatusNew", "message": ""}
2020-12-16T10:18:09.313-0300    WARN    graphsync_network       network/libp2p_impl.go:65       error setting deadline: set pipe: deadline not supported
2020-12-16T10:18:09.314-0300    INFO    markets loggers/loggers.go:25   retrieval event {"name": "ClientEventDealProposed", "deal ID": "0", "state": "DealStatusWaitForAcceptance", "message": ""}
2020-12-16T10:18:09.315-0300    WARN    graphsync_network       network/libp2p_impl.go:79       error resetting deadline: set pipe: deadline not supported
2020-12-16T10:18:09.318-0300    INFO    markets loggers/loggers.go:30   retrieval event {"name": "ProviderEventOpen", "deal ID": "0", "receiver": "12D3KooWDsnTCj47cRHoBtHcaiiM73dAfqX2FKJr5VpM4heQ6Quz", "state": "DealStatusNew", "message": ""}
2020-12-16T10:18:09.321-0300    INFO    markets loggers/loggers.go:30   retrieval event {"name": "ProviderEventDealAccepted", "deal ID": "0", "receiver": "12D3KooWDsnTCj47cRHoBtHcaiiM73dAfqX2FKJr5VpM4heQ6Quz", "state": "DealStatusUnsealing", "message": ""}
panic: implme

goroutine 12455 [running]:
github.com/filecoin-project/lotus/extern/sector-storage/mock.(*SectorMgr).ReadPiece(0xc0009d8e20, 0x3dd3720, 0xc000124018, 0x3d9b6a0, 0xc00b396258, 0x3e8, 0x3, 0x2, 0x0, 0x7f00000, ...)
        /home/ignacio/go/pkg/mod/github.com/filecoin-project/[email protected]/extern/sector-storage/mock/mock.go:351 +0x350
github.com/filecoin-project/lotus/markets/retrievaladapter.(*retrievalProviderNode).UnsealSector.func1(0xc0093b2000, 0xc000aa9b60, 0x3dd3720, 0xc000124018, 0xc00b396258, 0x3e8, 0x3, 0x2, 0x0, 0x7f00000)
        /home/ignacio/go/pkg/mod/github.com/filecoin-project/[email protected]/markets/retrievaladapter/provider.go:70 +0x1a5
created by github.com/filecoin-project/lotus/markets/retrievaladapter.(*retrievalProviderNode).UnsealSector
        /home/ignacio/go/pkg/mod/github.com/filecoin-project/[email protected]/markets/retrievaladapter/provider.go:65 +0x52b

This happens when using 512MiB sectors for the mocked sector-storage.

The original PR for this still exists but was never merged so I'm always doing this patch on every new release for lotus-devnet.

cc @arajasek

@jsign
improve mocked readpiece
f6cf27c 
Signed-off-by: Ignacio Hagopian <[email protected]>
@jsign jsign marked this pull request as ready for review December 21, 2020 14:34
magik6k
magik6k approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@magik6k magik6k merged commit 44a56c7 into filecoin-project:master Jan 5, 2021
bibibong pushed a commit to EpiK-Protocol/go-epik that referenced this pull request Jan 9, 2021
@magik6k @bibibong
Merge pull request filecoin-project#5208 from jsign/jsign/imprreadpiece
dfca87b 
sector-storage/mock: improve mocked readpiece
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsign @magik6k